Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mev_simBundle #11252

Merged
merged 6 commits into from
Sep 28, 2024
Merged

feat: mev_simBundle #11252

merged 6 commits into from
Sep 28, 2024
+77 −1

Conversation

SkandaBhat
Copy link
Contributor

Towards #9472

@SkandaBhat SkandaBhat closed this Sep 26, 2024
@SkandaBhat SkandaBhat reopened this Sep 27, 2024
@SkandaBhat SkandaBhat changed the title mev_simBundle feat: mev_simBundle Sep 27, 2024
mattsse
mattsse requested changes Sep 27, 2024
View reviewed changes
crates/rpc/rpc/src/eth/bundle.rs Outdated
@@ -269,6 +283,20 @@ where
}
}

#[async_trait::async_trait]
impl<Eth> MevSimApiServer for EthBundle<Eth>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for EthSimBundle, we want a standalone type, this way we have a nice separation of namespaces

mattsse
mattsse approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
we can get this in and work on the impl separately

cc @ryanschneider

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Sep 28, 2024
@mattsse mattsse marked this pull request as ready for review September 28, 2024 13:11
@mattsse mattsse added this pull request to the merge queue Sep 28, 2024
Merged via the queue into paradigmxyz:main with commit 4850c29 Sep 28, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkandaBhat @mattsse